Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install platforms for the specified api level #384

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Install platforms for the specified api level #384

merged 2 commits into from
Mar 27, 2024

Conversation

joshrlesch
Copy link
Contributor

When using this action in multiple projects that both build and test Android apps on shared self-hosted runners. We are having emulator launch issues because the platform is missing in the Android SDK.

When only building, we use the setup-android action to install the Android SDK. If another test build hits the same self-hosted runner with a cached Android SDK directory, the platforms directory does not get installed by this GH action.

WARNING | platforms subdirectory is missing under /Users/ec2-user/.android/sdk, please install it
  WARNING | invalid sdk root /Users/ec2-user/.android/sdk
  PANIC: Broken AVD system path. Check your ANDROID_SDK_ROOT value [/Users/ec2-user/.android/sdk]!
  INFO    | Android emulator version 32.1.15.0 (build_id 10696886) (CL:N/A)
  INFO    | checking ANDROID_HOME for valid sdk root.
  INFO    | checking ANDROID_SDK_ROOT for valid sdk root.
  emulator: WARN: Cannot find valid sdk root from environment variable ANDROID_HOME nor ANDROID_SDK_ROOT,Try to infer from emulator's path
  INFO    | guessed sdk root is /Users/ec2-user/.android/sdk
  emulator: WARN: Cannot find valid sdk root path.

It seems like other people are also running into the same issue, ie -> #375

@max-kammerer
Copy link

@ychescale9 Could you please merge these changes and publish new release?

@ychescale9 ychescale9 merged commit 1fef06a into ReactiveCircus:main Mar 27, 2024
7 checks passed
@ychescale9
Copy link
Member

Thanks!

@joshrlesch joshrlesch deleted the JL-InstallPlatforms branch March 28, 2024 13:29
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Apr 18, 2024
Closed
@yachi
Copy link

yachi commented Apr 23, 2024

is it fix released yet?

ychescale9 added a commit that referenced this pull request May 24, 2024
@ychescale9
Merge branch 'main' into release/v2
77986be 
* main:
  Prepare for release 2.31.0.
  Install platforms for the specified api level (#384)
  Add api level `VanillaIceCream` support (#378)
  Bump Gradle wrapper validation from v1 to v2 to use Node 20 (#374)
  Migrate to Node 20 on CI via GitHub Actions major upgrades (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshrlesch @max-kammerer @ychescale9 @yachi